Clean up surface.F90 and simplify nst_land_fill with FieldBundle loop #517
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… vegeation type from the input grid on the target grid. Addresses Issue ufs-community#246.
… a field bundle. Addresses Issue ufs-community#516
…feature/surface_cleanup
|
I'll make this PR again shortly. It looks like I built these changes on top of the wrong branch. I'll re-build on top of develop and re-submit. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses Issue #516
I removed some old code that's no longer used and converted nst_land_fill to using a FieldBundle loop to cut down on code length. I also wrote a test for this subroutine that checks that land points in all of the various nst fields are being set properly. All tests pass as do the old system tests.